ENCODE code review process: Difference between revisions
From genomewiki
Jump to navigationJump to search
(first draft) |
|||
Line 1: | Line 1: | ||
== ENCODE Wranglers == | == ENCODE Wranglers == | ||
NOTE that sometimes | NOTE that sometimes ENCODE Developers perform wrangling duties -- when they do, the first two rules apply to them as well. | ||
* When reviewing a wrangler's check-ins, you must thoroughly check: .daf, scripts (perl, python, etc.) | * When reviewing a wrangler's check-ins, you must thoroughly check: .daf, scripts (perl, python, etc.) | ||
* When reviewing a wrangler's check-ins, for the sake of consistency and spreading general knowledge about the project, you should lightly check html, configuration and notes files such as: .ra, notes, .txt, .html | * When reviewing a wrangler's check-ins, for the sake of consistency and spreading general knowledge about the project, you should lightly check html, configuration and notes files such as: .ra, notes, .txt, .html |
Revision as of 22:19, 6 December 2010
ENCODE Wranglers
NOTE that sometimes ENCODE Developers perform wrangling duties -- when they do, the first two rules apply to them as well.
- When reviewing a wrangler's check-ins, you must thoroughly check: .daf, scripts (perl, python, etc.)
- When reviewing a wrangler's check-ins, for the sake of consistency and spreading general knowledge about the project, you should lightly check html, configuration and notes files such as: .ra, notes, .txt, .html
- Until further notice, Kate will review wrangler's code (.c) check-ins.
ENCODE Developers
- When reviewing an ENCODE developer's check-ins, don't gloss over ENCODE pipeline edits.
ENCODE QAers
NOTE that as ENOCDE QAers do the actual QA of the tracks they will, by default, check all other changes that have been made by any ENCODEr to .ra and .html files.
- ENCODE QAers will review all check-ins (.html, .ra, etc).
cv.ra file
- Melissa will review all cv.ra commits from the previous week.
- Katrina will review Melissa's cv.ra commits from the previous week.